jorisvandenbossche commented on code in PR #14574:
URL: https://github.com/apache/arrow/pull/14574#discussion_r1016812065
##########
python/pyarrow/parquet/core.py:
##########
@@ -3430,10 +3430,14 @@ def write_metadata(schema, where,
metadata_collector=None, **kwargs):
if metadata_collector is not None:
# ParquetWriter doesn't expose the metadata until it's written. Write
# it and read it again.
- metadata = read_metadata(where)
+ metadata = read_metadata(where, filesystem=kwargs.get("filesystem"))
Review Comment:
I think we can still explicitly add a filesystem keyword to the
`write_metadata` signature instead through kwargs; that makes it more
discoverable for the user (and then also document it in the docstring), and is
consistent with other functions in this module that support this keyword.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
