rtpsw commented on PR #14043: URL: https://github.com/apache/arrow/pull/14043#issuecomment-1310100867
> @pitrou, the [CI job's](https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/45338410) failure copied below seems to need attention. The reason for the error is that the Arrow function `cast` is being called with a `Table` argument whereas `arrow::compute::internal::GetFunctionArgumentTypes(...)`, which is invoked by `arrow::compute::<anonymous>::ExecuteInternal` and `arrow::compute::GetFunctionExecutor`, expects array or scalar argument only, as checked by `arrow::compute::internal::CheckAllArrayOrScalar(...)`. However, the [current pre-PR Arrow code](https://github.com/apache/arrow/tree/4e99f59dc111b0957a468ecaf1a6f865078be1c9) has the same implementation of `arrow::compute::internal::CheckAllArrayOrScalar(...)` which is invoked by `arrow::compute::<anonymous>::ExecuteInternal` before [dealing with `cast`](https://github.com/apache/arrow/blob/4e99f59dc111b0957a468ecaf1a6f865078be1c9/cpp/src/arrow/compute/function.cc#L251-L256), so one would expect the same error for the current Arrow code. Presumably, the current Arrow code passed CI and the error didn't happen for it. But then, I don't see yet why this PR's code is different. I'd like to understand this before trying to fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
