rtpsw commented on code in PR #14352:
URL: https://github.com/apache/arrow/pull/14352#discussion_r1019618462
##########
cpp/src/arrow/compute/kernels/hash_aggregate_test.cc:
##########
@@ -71,6 +71,31 @@ using internal::checked_pointer_cast;
namespace compute {
namespace {
+Result<Datum> AlternatorGroupBy(const std::vector<Datum>& arguments,
Review Comment:
IIRC, the intention was to cover both code paths in various existing test
cases, but I couldn't easily find a way to do this both clean and simple, and I
opted for simple. I'm not happy about this either. I'll think about how to
clean this up when I get back to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
