alamb commented on code in PR #4156:
URL: https://github.com/apache/arrow-datafusion/pull/4156#discussion_r1022929133
##########
datafusion/core/src/physical_plan/hash_utils.rs:
##########
@@ -0,0 +1,830 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
I don't understand this file -- it looks like maybe it was previously moved
into physical-expr and maybe a merge conflict caused it to end up here?
```
find . -name 'hash_utils.rs'
./datafusion/core/src/physical_plan/hash_utils.rs
./datafusion/physical-expr/src/hash_utils.rs
``
##########
datafusion/core/tests/sql/select.rs:
##########
@@ -814,6 +814,8 @@ async fn query_on_string_dictionary() -> Result<()> {
];
assert_batches_eq!(expected, &actual);
+ // filtering with Time32 and Time64 types
Review Comment:
this comment seems out of place
##########
datafusion/proto/src/lib.rs:
##########
@@ -606,9 +606,21 @@ mod roundtrip_tests {
ScalarValue::Date32(Some(0)),
ScalarValue::Date32(Some(i32::MAX)),
ScalarValue::Date32(None),
- ScalarValue::Time64(Some(0)),
- ScalarValue::Time64(Some(i64::MAX)),
- ScalarValue::Time64(None),
+ ScalarValue::Date64(Some(0)),
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
