jackwener commented on code in PR #4185:
URL: https://github.com/apache/arrow-datafusion/pull/4185#discussion_r1023476969
##########
datafusion/sql/src/planner.rs:
##########
@@ -2854,41 +2741,6 @@ fn normalize_sql_object_name(sql_object_name:
&ObjectName) -> String {
.join(".")
}
-/// Remove join expressions from a filter expression
-fn remove_join_expressions(
- expr: &Expr,
- join_columns: &HashSet<(Column, Column)>,
-) -> Result<Option<Expr>> {
- match expr {
- Expr::BinaryExpr(BinaryExpr { left, op, right }) => match op {
- Operator::Eq => match (left.as_ref(), right.as_ref()) {
- (Expr::Column(l), Expr::Column(r)) => {
- if join_columns.contains(&(l.clone(), r.clone()))
- || join_columns.contains(&(r.clone(), l.clone()))
- {
- Ok(None)
- } else {
- Ok(Some(expr.clone()))
- }
- }
- _ => Ok(Some(expr.clone())),
- },
- Operator::And => {
- let l = remove_join_expressions(left, join_columns)?;
- let r = remove_join_expressions(right, join_columns)?;
- match (l, r) {
- (Some(ll), Some(rr)) => Ok(Some(and(ll, rr))),
- (Some(ll), _) => Ok(Some(ll)),
- (_, Some(rr)) => Ok(Some(rr)),
- _ => Ok(None),
- }
- }
- _ => Ok(Some(expr.clone())),
- },
- _ => Ok(Some(expr.clone())),
- }
Review Comment:
I don't know who revert these code, this originally include `handle OR`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
