isidentical commented on code in PR #4240: URL: https://github.com/apache/arrow-datafusion/pull/4240#discussion_r1024080106
########## datafusion/expr/src/expr_fn.rs: ########## @@ -366,8 +366,8 @@ unary_scalar_expr!(Round, round, "round to nearest integer"); unary_scalar_expr!(Trunc, trunc, "truncate toward zero"); unary_scalar_expr!(Abs, abs, "absolute value"); unary_scalar_expr!(Signum, signum, "sign of the argument (-1, 0, +1) "); -unary_scalar_expr!(Exp, exp, "base 2 logarithm"); -unary_scalar_expr!(Log2, log2, "base 10 logarithm"); +unary_scalar_expr!(Exp, exp, "exponent"); Review Comment: Very minor thing (mainly for consistency), but since most of the functions here mirror the [Postgres documentation](https://www.postgresql.org/docs/7.1/functions-math.html), maybe we should use it for the `exp()` as well. ```suggestion unary_scalar_expr!(Exp, exp, "exponential"); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
