save-buffer commented on code in PR #14225:
URL: https://github.com/apache/arrow/pull/14225#discussion_r1024653166
##########
cpp/src/arrow/testing/random.h:
##########
@@ -49,7 +50,9 @@ class ARROW_TESTING_EXPORT RandomArrayGenerator {
/// \param[in] null_probability the probability of a bit being zero
///
/// \return a generated Buffer
- std::shared_ptr<Buffer> NullBitmap(int64_t size, double null_probability =
0);
+ std::shared_ptr<Buffer> NullBitmap(int64_t size, double null_probability = 0,
+ int64_t alignment =
kDefaultBufferAlignment,
+ MemoryPool* memory_pool = NULLPTR);
Review Comment:
Sure, that also works. The effect will be the same as it eventually all goes
down into
```
if (pool == nullptr) {
pool = default_memory_pool();
mm = default_cpu_memory_manager();
} else {
mm = CPUDevice::memory_manager(pool);
}
```
inside of `memory_pool.cc`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
