[GitHub] [arrow] kou commented on a diff in pull request #14664: MINOR: [Release] Add RC number and version to verify release candidate success message

Thu, 17 Nov 2022 11:20:33 -0800 


kou commented on code in PR #14664:
URL: https://github.com/apache/arrow/pull/14664#discussion_r1025605908


##########
dev/release/verify-release-candidate.sh:
##########
@@ -1198,5 +1198,5 @@ test_binary_distribution
 
 TEST_SUCCESS=yes
 
-echo 'Release candidate looks good!'
+echo "Release candidate number: ${RC_NUMBER} for version: ${VERSION} looks 
good!"

Review Comment:
   It's not a strong opinion but how about simplifying it?
   
   ```suggestion
   echo "Release candidate ${VERSION}-RC${RC_NUMBER} looks good!"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to