emkornfield commented on code in PR #14603:
URL: https://github.com/apache/arrow/pull/14603#discussion_r1025828815
##########
cpp/src/parquet/metadata.h:
##########
@@ -182,6 +182,28 @@ class PARQUET_EXPORT ColumnChunkMetaData {
std::unique_ptr<ColumnChunkMetaDataImpl> impl_;
};
+/// \brief DataPageStats is a proxy around stats in format::PageHeader.
+class PARQUET_EXPORT DataPageStats {
+ public:
+ static std::unique_ptr<DataPageStats> Make(const void* page_header);
+
+ ~DataPageStats();
+
+ bool Equals(const DataPageStats& other) const;
+
+ int32_t num_values() const;
Review Comment:
EncodedStatistics looks almost identical to this though? For normal
statistics It looks the like the descriptor is only needed to construct a
comparator, I wonder if there is some refactoring that could separate the two?
It seems like having a 3rd type of statitistics would add confusion, so I want
to make sure there is a strong reason to add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
