westonpace commented on code in PR #14663:
URL: https://github.com/apache/arrow/pull/14663#discussion_r1032885179


##########
cpp/src/arrow/dataset/file_base.h:
##########
@@ -108,6 +115,9 @@ class ARROW_DS_EXPORT FileSource : public 
util::EqualityComparable<FileSource> {
   /// \brief Get a RandomAccessFile which views this file source
   Result<std::shared_ptr<io::RandomAccessFile>> Open() const;
 
+  /// \brief Get the size (in bytes) of the file or buffer

Review Comment:
   Ah, I misunderstood and thought we were talking about a different size.  
This size could pose a problem for compressed streams.  It should ideally be 
the uncompressed size but I don't think that is easily available.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to