mingmwang commented on code in PR #4365:
URL: https://github.com/apache/arrow-datafusion/pull/4365#discussion_r1034729820
##########
datafusion/optimizer/src/push_down_filter.rs:
##########
@@ -1159,26 +1064,24 @@ mod tests {
\n Limit: skip=0, fetch=20\
\n Projection: test.a, test.b\
\n TableScan: test";
- assert_optimized_plan_eq(&plan, expected);
- Ok(())
+ assert_optimized_plan_eq(&plan, expected)
}
#[test]
fn union_all() -> Result<()> {
let table_scan = test_table_scan()?;
- let plan = LogicalPlanBuilder::from(table_scan.clone())
- .union(LogicalPlanBuilder::from(table_scan).build()?)?
+ let table_scan2 = test_table_scan_with_name("test2")?;
Review Comment:
Could you please add one more UT to cover the case that the union's inputs
have different named Field case ? There maybe implicit type conversions here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
