jackwener commented on PR #4412: URL: https://github.com/apache/arrow-datafusion/pull/4412#issuecomment-1330710406
> I think SubqueryAlias is just temp struct in the plan tree for scoping names. The SubqueryAlias should be removed totally from the plan tree at an early phase of the logical planing by modifying the inner plan's qualify names. > Then the rest of the other logical rules do not need to deal with SubqueryAlias anymore. Look like we can add it in planner. When we add `subquery alias`, if child is `subquery alias`, we just need to change the name. I don't have much preference for these two options. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org