emkornfield commented on code in PR #14742:
URL: https://github.com/apache/arrow/pull/14742#discussion_r1035188213
##########
cpp/src/parquet/metadata.h:
##########
@@ -171,6 +171,13 @@ class PARQUET_EXPORT ColumnChunkMetaData {
int64_t total_uncompressed_size() const;
std::unique_ptr<ColumnCryptoMetaData> crypto_metadata() const;
+ bool has_column_index() const;
+ int64_t column_index_offset() const;
Review Comment:
I think it might be a clearer contract to have something like:
```
struct IndexLocation {
int64_t index_file_offset_bytes;
int32_t offset_index_length
}
optional<IndexLocation> GetColumIndexLocation();
optional<IndexLocation> GetOffsetIndexLocation();
```
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
