mustafasrepo opened a new pull request, #4439:
URL: https://github.com/apache/arrow-datafusion/pull/4439
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #4438.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
We can't rely on the current `output_ordering` result unless we pass from
the `BasicEnforcement` optimization pass. Hence `output_ordering` of the
`WindowAggExec` would give the wrong result during physical plan
[planner](https://github.com/apache/arrow-datafusion/blob/fdc83e8524df30ac5d0ae097572b7c48dc686ba9/datafusion/core/src/physical_plan/planner.rs#L463)
# What changes are included in this PR?
Since `WindowAggExec` maintains input order and requires specific ordering,
output ordering would be required input ordering. I have changed code to
reflect that (By this way we can rely on `output_ordering` information of
`WindowAggExec` even if there is currently no `SortExec` before it in the
physical plan)
# Are these changes tested?
N.A
# Are there any user-facing changes?
N.A
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
