mingmwang commented on issue #4438: URL: https://github.com/apache/arrow-datafusion/issues/4438#issuecomment-1332955174
WindowAggExec does not change the ordering of the input. If you make a call to `output_ordering()` method before the `BasicEnforcement` pass, it just reflect the facts that the output ordering is the same as its input. As I explained in the PR, we should not mix the `required` ordering with the `real` ordering, they are not always the same. If you check the other physical operators implementation, the `output_ordering()` method should return: 1) Return `Non` if the operator can not keep any ordering. 2) Return the `input ordering` if the operator can keep the input ordering unchanged. 3) Return some `Exprs`, if the operator itself can reorder the stream batches, for example `SortExec`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
