raulcd commented on code in PR #14750:
URL: https://github.com/apache/arrow/pull/14750#discussion_r1037053927
##########
dev/test_merge_arrow_pr.py:
##########
@@ -332,9 +346,10 @@ def test_jira_output_no_components():
def test_sorting_versions():
versions_json = [
+ {'name': '11.0.0', 'released': False},
{'name': '9.0.0', 'released': False},
{'name': '10.0.0', 'released': False},
]
versions = [FakeVersion(raw['name'], raw) for raw in versions_json]
- ordered_versions = merge_arrow_pr.JiraIssue.sort_versions(versions)
- assert ordered_versions[0].name == "10.0.0"
+ fix_version = merge_arrow_pr.get_candidate_fix_version(versions)
+ assert fix_version == "9.0.0"
Review Comment:
Sounds like a good idea. I've added a ticket to track this separately if
that's ok: https://github.com/apache/arrow/issues/14802
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
