Ted-Jiang commented on code in PR #4485:
URL: https://github.com/apache/arrow-datafusion/pull/4485#discussion_r1038919554
##########
datafusion/proto/src/from_proto.rs:
##########
@@ -806,11 +806,20 @@ pub fn parse_expr(
.ok_or_else(|| Error::unknown("BuiltInWindowFunction",
*i))?
.into();
+ let args = match parse_optional_expr(&expr.expr,
registry)? {
+ None => {
+ vec![]
+ }
+ Some(x) => {
Review Comment:
souds good, i try it but seems `Vec::new` can not create one size vec with
one agrs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
