wgtmac commented on code in PR #14806:
URL: https://github.com/apache/arrow/pull/14806#discussion_r1039763181
##########
cpp/src/arrow/adapters/orc/adapter.cc:
##########
@@ -217,6 +217,8 @@ class ORCFileReader::Impl {
int64_t NumberOfRows() { return
static_cast<int64_t>(reader_->getNumberOfRows()); }
+ int64_t NumberOfRows(int64_t stripe) { return stripes_[stripe].num_rows; }
Review Comment:
It seems that the orc adapter already throws exceptions from liborc. Maybe
it is good enough to throw `liborc::InvalidArgument` for now.
##########
cpp/src/arrow/adapters/orc/adapter.cc:
##########
@@ -217,6 +217,8 @@ class ORCFileReader::Impl {
int64_t NumberOfRows() { return
static_cast<int64_t>(reader_->getNumberOfRows()); }
+ int64_t NumberOfRows(int64_t stripe) { return stripes_[stripe].num_rows; }
Review Comment:
@kou Can you advise if we need to be more consistent to the project style
which returns status instead of throwing exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
