alamb commented on code in PR #4490:
URL: https://github.com/apache/arrow-datafusion/pull/4490#discussion_r1042057448
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -272,11 +279,31 @@ impl LogicalPlanBuilder {
/// Apply a filter
pub fn filter(&self, expr: impl Into<Expr>) -> Result<Self> {
+ self.filter_with_params(expr, &[])
+ }
+
+ /// Apply a filter wit provided data types for params of prepared
statement
+ pub fn filter_with_params(
Review Comment:
I am worried about this approach -- now clients will have to know if they
should call `filter` or `filter_with_params` depending on the context.
Can you think of any way to avoid it?
Update: I have a suggestion
https://github.com/apache/arrow-datafusion/pull/4490#discussion_r1042191919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
