[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #4534: Minor: Avoid cloning some `Ident` as much during planning

[GitBox]

alamb commented on code in PR #4534:
URL: https://github.com/apache/arrow-datafusion/pull/4534#discussion_r1042598680


##########
datafusion/sql/src/planner.rs:
##########
@@ -661,7 +659,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
                 .iter()
                 .any(|x| x.option == ColumnOption::Null);
             fields.push(Field::new(
-                &normalize_ident(&column.name),
+                &normalize_ident(column.name),

Review Comment:
   This is unfortunate to simply drop the `String` immediately, but 
`Field::new` requires a `&str` (it can't take the String). Filed XX upstream: 
https://github.com/apache/arrow-rs/pull/3288/files



##########
datafusion/sql/src/planner.rs:
##########
@@ -661,7 +659,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
                 .iter()
                 .any(|x| x.option == ColumnOption::Null);
             fields.push(Field::new(
-                &normalize_ident(&column.name),
+                &normalize_ident(column.name),

Review Comment:
   This is unfortunate to simply drop the `String` immediately, but 
`Field::new` requires a `&str` (it can't take the String). Filed upstream: 
https://github.com/apache/arrow-rs/pull/3288/files



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org