alamb opened a new pull request, #4582: URL: https://github.com/apache/arrow-datafusion/pull/4582
# Which issue does this PR close? As promised on https://github.com/apache/arrow-datafusion/pull/4488 # Rationale for this change All actual aggregate implementations use `AggregateState::Scalar` It is bad to have `AggregateState::Array` because: 1. It does not work for queries with more than 1 partition (which is almost any real world query), see https://github.com/apache/arrow-datafusion/pull/4488 for more details 2. It obscures how aggregates actually work, which is already complicated, with an extra layer of indirection # What changes are included in this PR? 1. Remove AggregateState wrapper # Are these changes tested? yes, covered by existing tests # Are there any user-facing changes? yes -- User defined aggregates are now simpler to write / less error prone cc @andygrove as he originally wrote this code in https://github.com/apache/arrow-datafusion/pull/3009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
