rtpsw commented on code in PR #14682:
URL: https://github.com/apache/arrow/pull/14682#discussion_r1045248240
##########
python/pyarrow/src/arrow/python/udf.cc:
##########
@@ -83,16 +135,17 @@ struct PythonUdf : public compute::KernelState {
}
};
-Status PythonUdfExec(compute::KernelContext* ctx, const ExecSpan& batch,
- ExecResult* out) {
+Status PythonUdfExec(compute::KernelContext* ctx, const compute::ExecSpan&
batch,
+ compute::ExecResult* out) {
auto udf = static_cast<PythonUdf*>(ctx->kernel()->data.get());
return SafeCallIntoPython([&]() -> Status { return udf->Exec(ctx, batch,
out); });
}
-} // namespace
-
-Status RegisterScalarFunction(PyObject* user_function,
ScalarUdfWrapperCallback wrapper,
- const ScalarUdfOptions& options) {
+Status RegisterScalarLikeFunction(PyObject* user_function,
Review Comment:
I agree the name "scalar" is confusing. Perhaps just drop the "scalar" word
and stay with just "Udf", e.g., `UdfWrapperCallback`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
