[GitHub] [arrow] mapleFU commented on a diff in pull request #14351: ARROW-17904: [C++] Parquet Implement crc in reading and writing Page for DATA_PAGE (v1)

[GitBox]

mapleFU commented on code in PR #14351:
URL: https://github.com/apache/arrow/pull/14351#discussion_r1046069341


##########
cpp/src/parquet/column_reader.cc:
##########
@@ -400,6 +401,19 @@ std::shared_ptr<Page> SerializedPageReader::NextPage() {
       ParquetException::EofException(ss.str());
     }
 
+    const PageType::type page_type = LoadEnumSafe(&current_page_header_.type);
+
+    if (properties_.use_page_checksum_verification() &&
+        page_type == PageType::DATA_PAGE && current_page_header_.__isset.crc) {

Review Comment:
   As mentioned in https://issues.apache.org/jira/browse/ARROW-17904 , this 
patch will only add DATA_PAGE_V1 here, because:
   * DATA_PAGE_V2's checksum need to considering rep-level and def-levels, 
which may doesn't share the same processing logic
   * parquet-mr doesn't implement checksum over DATA_PAGE_V1. For implement C++ 
code, it doesn't matter, but if we will lack the ability of cross-validation. 
So maybe later I'd like to add in parquet-mr first.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org