tustvold commented on code in PR #4606:
URL: https://github.com/apache/arrow-datafusion/pull/4606#discussion_r1047605791
##########
datafusion/core/src/catalog/information_schema.rs:
##########
@@ -117,15 +121,19 @@ impl CatalogProvider for CatalogWithInformationSchema {
/// providers, they will appear the next time the `information_schema`
/// table is queried.
struct InformationSchemaProvider {
+ config: InformationSchemaConfig,
+}
+
+#[derive(Clone)]
+struct InformationSchemaConfig {
catalog_list: Arc<dyn CatalogList>,
config_options: Arc<RwLock<ConfigOptions>>,
}
-impl InformationSchemaProvider {
+impl InformationSchemaConfig {
/// Construct the `information_schema.tables` virtual table
- fn make_tables(&self) -> Arc<dyn TableProvider> {
+ fn make_tables(&self, builder: &mut InformationSchemaTablesBuilder) {
Review Comment:
The signature of these is now a little bit strange, but I wanted to try to
minimise code movement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
