save-buffer commented on code in PR #14227:
URL: https://github.com/apache/arrow/pull/14227#discussion_r1051189033
##########
cpp/src/arrow/compute/exec/exec_plan.cc:
##########
@@ -357,9 +313,15 @@ std::optional<int> GetNodeIndex(const
std::vector<ExecNode*>& nodes,
const uint32_t ExecPlan::kMaxBatchSize;
+Result<std::shared_ptr<ExecPlan>> ExecPlan::Make(
+ QueryOptions opts, ExecContext* ctx,
+ std::shared_ptr<const KeyValueMetadata> metadata) {
+ return std::shared_ptr<ExecPlan>(new ExecPlanImpl{opts, ctx,
std::move(metadata)});
+}
+
Result<std::shared_ptr<ExecPlan>> ExecPlan::Make(
ExecContext* ctx, std::shared_ptr<const KeyValueMetadata> metadata) {
- return std::shared_ptr<ExecPlan>(new ExecPlanImpl{ctx, metadata});
+ return Make({}, ctx, std::move(metadata));
Review Comment:
Added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
