alamb commented on code in PR #3384:
URL: https://github.com/apache/arrow-rs/pull/3384#discussion_r1054841288
##########
arrow-arith/src/arithmetic.rs:
##########
@@ -332,11 +316,7 @@ where
valid_chunks
.iter()
- .zip(
- result_chunks
- .borrow_mut()
-
.zip(left_chunks.borrow_mut().zip(right_chunks.borrow_mut())),
- )
+ .zip((&mut result_chunks).zip((&mut left_chunks).zip(&mut
right_chunks)))
Review Comment:
this doesn't need mut references, is that the difference?
##########
arrow-arith/src/arithmetic.rs:
##########
@@ -22,29 +22,12 @@
//! `RUSTFLAGS="-C target-feature=+avx2"` for example. See the documentation
//! [here](https://doc.rust-lang.org/stable/core/arch/) for more information.
-use crate::array::*;
-#[cfg(feature = "simd")]
-use crate::buffer::MutableBuffer;
-use crate::compute::kernels::arity::unary;
-use crate::compute::{
- binary, binary_opt, try_binary, try_unary, try_unary_dyn, unary_dyn,
-};
-use crate::datatypes::{
- ArrowNativeTypeOp, ArrowNumericType, DataType, Date32Type, Date64Type,
- IntervalDayTimeType, IntervalMonthDayNanoType, IntervalUnit,
IntervalYearMonthType,
-};
-#[cfg(feature = "dyn_arith_dict")]
Review Comment:
what changed about the feature guards that allows for this simplification?
##########
arrow/src/compute/kernels/mod.rs:
##########
@@ -17,14 +17,9 @@
//! Computation kernels on Arrow Arrays
-pub mod aggregate;
-pub mod arithmetic;
-pub mod arity;
-pub mod bitwise;
-pub mod boolean;
pub mod limit;
Review Comment:
what is the deal with limit? Is it going away too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
