rtpsw commented on PR #14799: URL: https://github.com/apache/arrow/pull/14799#issuecomment-1362176832
I looked into the [ASAN failure](https://github.com/apache/arrow/actions/runs/3749800476/jobs/6368695073), and I suspect that it is because `ScheduleTask` is synchronous. In particular, I observed that the `ScheduleTask` invocation in `CheckEnded` is executed within the process-thread of the `AsofJoinNode`, which marks finished and leads to an invocation of `~AofJoinNode` within the same thread. This is why a `detach` invocation was added in this destructor, but this desctructor shouldn't be called from the process-thread. The actual ASAN failure happened in a later invocation of `CheckEnded` from the process-thread, which doesn't expect this destructor to have been called. @westonpace, I suspect this means that, at least with the current threading structure of `AsofJoinNode`, we would need to ensure `ScheduleTask` is not synchronous - WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
