alamb commented on code in PR #4699:
URL: https://github.com/apache/arrow-datafusion/pull/4699#discussion_r1054888658
##########
datafusion/core/src/datasource/file_format/parquet.rs:
##########
@@ -1257,13 +1265,13 @@ mod tests {
}
async fn get_exec(
- ctx: &SessionContext,
+ ctx: &SessionState,
Review Comment:
I find the `ctx` name confusing
##########
datafusion/core/src/datasource/file_format/avro.rs:
##########
@@ -47,6 +48,7 @@ impl FileFormat for AvroFormat {
async fn infer_schema(
&self,
+ _ctx: &SessionState,
Review Comment:
I agree this makes much more sense 👍
##########
datafusion/core/src/datasource/file_format/avro.rs:
##########
@@ -124,9 +129,10 @@ mod tests {
#[tokio::test]
async fn read_limit() -> Result<()> {
let session_ctx = SessionContext::new();
- let task_ctx = session_ctx.task_ctx();
+ let ctx = session_ctx.state();
Review Comment:
maybe `state` would be a better name than `ctx` as there is already
`session_ctx` which is a Context 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
