westonpace commented on PR #14867: URL: https://github.com/apache/arrow/pull/14867#issuecomment-1363362840
@jorisvandenbossche it should be using an exec plan internally with an aggregate node. The aggregate node knows how to maintain state from batch to batch. However, I agree your example is pointing out a bug in my code. I'll take a look. @rtpsw I will try merging this with your branch (and then create a third PR) just to make sure it works. I don't know if I can get to it before tomorrow morning. Either way, if there is concern about this approach, we can merge yours and clean up with mine. The basic idea is that we have kernel functions for arrays / single batches and exec plans for multiple batches (which should include chunked arrays). I don't see any value in maintaining a third path for chunked arrays when they should just be a special case of multiple batches / exec plans. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
