ozankabak commented on PR #4691: URL: https://github.com/apache/arrow-datafusion/pull/4691#issuecomment-1363691524
We went through your comments and questions, @mustafasrepo will address them in detail today. Interestingly, the following initial thought I had about your second example > My gut feeling is that the second example you mention ought to be one of the cases this PR should handle -- we may be able to handle it by terminating the traversal "properly". seems to be wrong and there seems to be a reason why we are not removing that sort -- @mustafasrepo will discuss this too. Thanks again for the in-depth review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
