alamb commented on PR #4730: URL: https://github.com/apache/arrow-datafusion/pull/4730#issuecomment-1365870512
> But during those refactoring the person might remove the test along with the code This is definitely true. Tests such as @Dandandan and I are referring to do not guarantee code isn't broken. However, I for one, when reviewing PRs look quite carefully at the tests that are changed / modified so having them act as a "second check" I think it is fine for this PR to not have added tests, but I do think they serve an important purpose which is why I am belaboring this point -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
