alamb commented on code in PR #3326:
URL: https://github.com/apache/arrow-rs/pull/3326#discussion_r1057918661
##########
arrow-array/src/array/string_array.rs:
##########
@@ -734,4 +734,15 @@ mod tests {
let array = builder.finish();
assert_eq!(expected, array);
}
+
+ #[test]
+ fn test_into_builder_err() {
+ let array: StringArray = vec!["hello", "arrow"].into();
+
+ // Clone it, so we cannot get a mutable builder back
Review Comment:
👍
##########
arrow-array/src/builder/generic_bytes_builder.rs:
##########
@@ -53,8 +53,12 @@ impl<T: ByteArrayType> GenericByteBuilder<T> {
}
}
- /// Creates a new primitive array builder from buffers
- pub fn new_from_buffer(
+ /// Creates a new [`GenericByteBuilder`] from buffers.
+ ///
+ /// # Safety
+ /// This doesn't verify buffer contents as it assumes the buffers are from
existing and
+ /// valid [`GenericByteArray`].
+ pub unsafe fn new_from_buffer(
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
