kou commented on code in PR #15099:
URL: https://github.com/apache/arrow/pull/15099#discussion_r1057933823
##########
dev/release/download_rc_binaries.py:
##########
@@ -203,7 +203,9 @@ def _download_file(self, dest, asset):
"--header",
"Accept: application/octet-stream",
# Also retry 403s
- "--retry-all-errors",
+ "--retry",
+ "5",
Review Comment:
They are redundant because `download_url()` already have them.
##########
dev/release/download_rc_binaries.py:
##########
@@ -203,7 +203,9 @@ def _download_file(self, dest, asset):
"--header",
"Accept: application/octet-stream",
# Also retry 403s
- "--retry-all-errors",
+ "--retry",
+ "5",
+ "--fail"
Review Comment:
How about retrying without `--retry-all-errors` when `_download_url()` with
`--retry-all-errors` is failed?
```python
try:
self._download_url(..., "--retry-all-errors", ...)
except ...:
self._download_url(...)
```
Or we can check `curl` version to confirm whether we can use
`--retry-all-errors` or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
