tustvold commented on code in PR #4771: URL: https://github.com/apache/arrow-datafusion/pull/4771#discussion_r1059128681
########## datafusion/core/tests/sqllogictests/test_files/information_schema.slt: ########## @@ -103,9 +103,10 @@ query R SHOW ALL ---- datafusion.catalog.create_default_catalog_and_schema true +datafusion.catalog.format NULL +datafusion.catalog.has_header false datafusion.catalog.information_schema true datafusion.catalog.location NULL -datafusion.catalog.type NULL Review Comment: `type` is a reserved keyword in rust, and the name was pretty overloaded anyway, so I opted to rename this to `format`. Amusingly this was already what the local variables were named as -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
