[GitHub] [arrow] nealrichardson commented on a change in pull request #8256: ARROW-9001: [R] Box outputs as correct type in call_function

Wed, 28 Oct 2020 08:22:24 -0700 


nealrichardson commented on a change in pull request #8256:
URL: https://github.com/apache/arrow/pull/8256#discussion_r513533285



##########
File path: r/R/filesystem.R
##########
@@ -285,6 +262,7 @@ FileSystem <- R6Class("FileSystem", inherit = ArrowObject,
       # TODO: see fs package for glob/regexp filtering
       # TODO: verbose method that shows other attributes as df
       # TODO: print methods for FileInfo, SubTreeFileSystem, S3FileSystem
+      fs___FileSystem__OpenAppendStream(self, clean_path_rel(path))

Review comment:
       Here's one of your bugs
   
   ```suggestion
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to