sanjibansg commented on code in PR #15125:
URL: https://github.com/apache/arrow/pull/15125#discussion_r1061883069
##########
cpp/src/arrow/dataset/file_parquet.cc:
##########
@@ -98,6 +98,17 @@ Result<std::shared_ptr<SchemaManifest>> GetSchemaManifest(
return manifest;
}
+bool isNan(const Scalar& value) {
+ if (value.type->Equals(*float32())) {
+ const FloatScalar& float_scalar = checked_cast<const FloatScalar&>(value);
+ return std::isnan(float_scalar.value);
Review Comment:
Checking for validity now.
##########
cpp/src/arrow/dataset/file_parquet.cc:
##########
@@ -98,6 +98,17 @@ Result<std::shared_ptr<SchemaManifest>> GetSchemaManifest(
return manifest;
}
+bool isNan(const Scalar& value) {
+ if (value.type->Equals(*float32())) {
+ const FloatScalar& float_scalar = checked_cast<const FloatScalar&>(value);
+ return std::isnan(float_scalar.value);
Review Comment:
Checking for validity now first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
