felipecrv commented on code in PR #15083:
URL: https://github.com/apache/arrow/pull/15083#discussion_r1063463210
##########
cpp/src/arrow/compute/api_aggregate.h:
##########
@@ -186,16 +188,38 @@ class ARROW_EXPORT IndexOptions : public FunctionOptions {
/// \brief Configure a grouped aggregation
struct ARROW_EXPORT Aggregate {
+ Aggregate() = default;
+
+ Aggregate(std::string function, std::shared_ptr<FunctionOptions> options,
+ std::vector<FieldRef> target, std::string name = "")
+ : function(std::move(function)),
+ options(std::move(options)),
+ target(std::move(target)),
+ name(std::move(name)) {}
+
+ Aggregate(std::string function, std::shared_ptr<FunctionOptions> options,
+ FieldRef target, std::string name = "")
+ : Aggregate(std::move(function), std::move(options),
+ /*target=*/std::vector<FieldRef>{std::move(target)},
std::move(name)) {}
Review Comment:
Redundant indeed. I will remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
