viirya commented on code in PR #3482:
URL: https://github.com/apache/arrow-rs/pull/3482#discussion_r1063731658
##########
arrow-cast/src/cast.rs:
##########
@@ -3348,6 +3350,30 @@ where
Ok(Arc::new(b.finish()))
}
+// Packs the data as a BinaryDictionaryArray, if possible, with the
+// key types of K
+fn pack_binary_to_dictionary<K>(
+ array: &ArrayRef,
+ cast_options: &CastOptions,
+) -> Result<ArrayRef, ArrowError>
+where
Review Comment:
Perhaps we can have a generic one for both string and binary, I may try it
in a follow up work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
