mapleFU opened a new pull request, #15241: URL: https://github.com/apache/arrow/pull/15241
Problem is mentioned here: https://github.com/apache/arrow/issues/14923 This patch fixes that issue. But here I have 2 problems: * Testing: Should I just generate a "bad_record" with different bit width? I found it's hard for testing parquet with gmock. So if I want to mock some error logic in writer, I need to modify some code and cannot push them to master * `miniblock_values_sum += values_current_mini_block_;` should I use `AddWithOverflow`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
