Jefffrey commented on code in PR #4863:
URL: https://github.com/apache/arrow-datafusion/pull/4863#discussion_r1065051234
##########
datafusion/sql/src/relation/join.rs:
##########
@@ -142,10 +142,29 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
.build()
}
JoinConstraint::Natural => {
- // https://issues.apache.org/jira/browse/ARROW-10727
- Err(DataFusionError::NotImplemented(
- "NATURAL JOIN is not supported
(https://issues.apache.org/jira/browse/ARROW-10727)".to_string(),
- ))
+ // TODO: what if no common join cols? -> becomes cross join
Review Comment:
Yep, I think that's been implemented, just forgot to remove the TODOs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
