westonpace commented on code in PR #14287:
URL: https://github.com/apache/arrow/pull/14287#discussion_r1066368953
##########
cpp/src/arrow/compute/exec/expression.h:
##########
@@ -129,6 +129,20 @@ class ARROW_EXPORT Expression {
explicit Expression(Datum literal);
explicit Expression(Parameter parameter);
+ /*
+ Grammar:
+ Expr -> FieldRef | Literal | Call
+
+ FieldRef -> Field | Field FieldRef
+ Field -> . Name | [ Number ]
+
+ Literal -> $ TypeName : Value
Review Comment:
This is missing rules for escaping right? I think those need to be part of
the grammar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
