jdye64 commented on code in PR #4895:
URL: https://github.com/apache/arrow-datafusion/pull/4895#discussion_r1069665783
##########
datafusion/substrait/src/producer.rs:
##########
@@ -74,6 +74,7 @@ pub fn to_substrait_plan(plan: &LogicalPlan) ->
Result<Box<Plan>> {
// Return parsed plan
Ok(Box::new(Plan {
+ version: None, // TODO not sure what version should go here?
Review Comment:
I don't know either so more of a question. Is this intended to be the
substrait version?? So in this context would be `0.3` you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
