alamb opened a new pull request, #4916: URL: https://github.com/apache/arrow-datafusion/pull/4916
# Which issue does this PR close? N/A # Rationale for this change 1. I want to make the code easier to understand (and thus lower the barrier to using DataFusion for new comers -- see #4903 ) 2. I enjoy making the code simpler to use Follow on to https://github.com/apache/arrow-datafusion/pull/4906 Some uses of `ExpressionVisitor` need its full power (visit both on pre/post traversal, see https://github.com/apache/arrow-datafusion/blob/d49c805c93498b542c130c77099b719f2a4ea8ba/datafusion/optimizer/src/common_subexpr_eliminate.rs#L421) but several uses just need a simple town down traversal. https://github.com/apache/arrow-datafusion/pull/4906 added a convenience function to do that traversal. # What changes are included in this PR? 1. Cleans up doc comments, 2. renames `walk_expr_down` to `inspect_expr_pre` 3. rewrites some other uses of ExpressionVisitor to use `inspect_expr_pre` to simplify them # Are these changes tested? Covered by existing tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
