heronshoes commented on code in PR #33654:
URL: https://github.com/apache/arrow/pull/33654#discussion_r1070747056
##########
ruby/red-arrow/test/test-table.rb:
##########
@@ -1230,20 +1241,95 @@ def setup
type: :inner))
end
- test("type:") do
+ test("type: :left_outer") do
table1 = Arrow::Table.new(key: [1, 2, 3],
number: [10, 20, 30])
table2 = Arrow::Table.new(key: [3, 1],
string: ["three", "one"])
assert_equal(Arrow::Table.new([
["key", [1, 3, 2]],
["number", [10, 30, 20]],
- ["key", [1, 3, nil]],
["string", ["one", "three", nil]],
]),
table1.join(table2, "key", type: :left_outer))
end
+ test("type: :right_outer") do
+ table1 = Arrow::Table.new(key: [1, 2, 3],
+ number: [10, 20, 30])
+ table2 = Arrow::Table.new(key: [3, 1],
+ string: ["three", "one"])
+ assert_equal(Arrow::Table.new([
+ ["key", [1, 3]],
+ ["number", [10, 30]],
+ ["string", ["one", "three"]],
+ ]),
+ table1.join(table2, "key", type: :right_outer))
+ end
+
+ test("type: :full_outer") do
+ table1 = Arrow::Table.new(key: [1, 2, 3],
+ number: [10, 20, 30])
+ table2 = Arrow::Table.new(key: [3, 1],
+ string: ["three", "one"])
+ assert_equal(Arrow::Table.new([
+ ["key", [1, 3, 2]],
+ ["number", [10, 30, 20]],
+ ["string", ["one", "three", nil]],
+ ]),
+ table1.join(table2, "key", type: :full_outer))
+ end
+
+ test("type: :left_semi") do
+ table1 = Arrow::Table.new(key: [1, 2, 3],
+ number: [10, 20, 30])
+ table2 = Arrow::Table.new(key: [3, 1],
+ string: ["three", "one"])
+ assert_equal(Arrow::Table.new([
+ ["key", [1, 3]],
+ ["number", [10, 30]],
+ ]),
+ table1.join(table2, "key", type: :left_semi))
+ end
+
+ test("type: :right_semi") do
+ table1 = Arrow::Table.new(key: [1, 2, 3],
+ number: [10, 20, 30])
+ table2 = Arrow::Table.new(key: [3, 1],
+ string: ["three", "one"])
+ assert_equal(Arrow::Table.new([
+ ["key", [3, 1]],
+ ["string", ["three", "one"]],
+ ]),
+ table1.join(table2, "key", type: :right_semi))
+ end
+
+ test("type: :left_anti") do
+ table1 = Arrow::Table.new(key: [1, 2, 3],
+ number: [10, 20, 30])
+ table2 = Arrow::Table.new(key: [3, 1],
+ string: ["three", "one"])
+ assert_equal(Arrow::Table.new([
+ ["key", [2]],
+ ["number", [20]],
+ ]),
+ table1.join(table2, "key", type: :left_anti))
+ end
+
+ test("type: :right_anti") do
+ table1 = Arrow::Table.new(key: [1, 2, 3],
+ number: [10, 20, 30])
+ table2 = Arrow::Table.new(key: [3, 1],
+ string: ["three", "one"])
+ assert_equal(Arrow::Table.new([
+ ["key", []],
+ ["string", []],
+ ]).to_s,
+ table1.join(table2, "key", type: :right_anti).to_s)
+ # There is a bug: right_anti result has incorrect chunked array.
+ # Temporarily compare #to_s result.
Review Comment:
```suggestion
]),
table1.join(table2, "key", type: :right_anti))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
