pitrou commented on code in PR #15244:
URL: https://github.com/apache/arrow/pull/15244#discussion_r1071045128
##########
cpp/src/parquet/properties.h:
##########
@@ -199,7 +199,8 @@ class PARQUET_EXPORT WriterProperties {
pagesize_(kDefaultDataPageSize),
version_(ParquetVersion::PARQUET_2_4),
data_page_version_(ParquetDataPageVersion::V1),
- created_by_(DEFAULT_CREATED_BY) {}
+ created_by_(DEFAULT_CREATED_BY),
+ integer_annotate_decimal_(false) {}
Review Comment:
Hi,
Some belated comments:
* Maybe it's because I am not a native English speaker, but I have a hard
time understanding what "integer annotate decimal" means. Is "annotate" a word
here?
* I agree that the defaults should remain false for the time being.
* While enabling this does allow for a more compact representation,
compression might at least partially alleviate that (though unfortunately
FIXED_LEN_BYTE_ARRAY doesn't seem to support any of the delta encodings)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
