davisusanibar commented on PR #15223: URL: https://github.com/apache/arrow/pull/15223#issuecomment-1385426991
I agree with all the changes. For easy to use, how do you see to start to implement BuilderPattern (the same feedback that I receive on https://github.com/apache/arrow/pull/11591/files#r741336548). These files contain Abstract Builder and Implementations: - Abstract: https://github.com/apache/arrow/blob/0a70a4029e49b771cacca071be773b39dac44974/java/vector/src/main/java/org/apache/arrow/vector/ipc/ArrowWriter.java#L225:L249 - Impl: https://github.com/apache/arrow/blob/0a70a4029e49b771cacca071be773b39dac44974/java/vector/src/main/java/org/apache/arrow/vector/ipc/ArrowStreamWriter.java#L88:L138 Please let mw know how do you see that to I could add this patch to this PR OR its should be handled in the another PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
