paleolimbot commented on code in PR #33614: URL: https://github.com/apache/arrow/pull/33614#discussion_r1072338394
########## r/R/dataset.R: ########## @@ -228,6 +228,131 @@ open_dataset <- function(sources, ) } +#' Open a multi-file dataset of CSV or other delimiter-separated format +#' +#' A wrapper around [open_dataset] which explicitly includes parameters mirroring [read_csv_arrow()], +#' [read_delim_arrow()], and [read_tsv_arrow()] to allows for easy switching between functions +#' for opening single files and functions for opening datasets. +#' +#' @inheritParams open_dataset +#' @inheritParams read_delim_arrow +#' +#' @section Options currently supported by [read_delim_arrow()] which are not supported here: +#' * `file` (instead, please specify files in `sources`) +#' * `col_select` (instead, subset columns after dataset creation) +#' * `quoted_na` +#' * `as_data_frame` (instead, convert to data frame after dataset creation) +#' * `parse_options` +#' +#' @examplesIf arrow_with_dataset() +#' # Set up directory for examples +#' tf <- tempfile() +#' dir.create(tf) +#' on.exit(unlink(tf)) Review Comment: It might work...`on.exit()` when the current environment is the global environment is a little hairy (`on.exit(..., add = TRUE)` would be *more* correct, but some other `on.exit()` *without* `add = TRUE` might cause the cleanup code you added not to run, if my understanding of `on.exit()` is correct). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
