tustvold commented on code in PR #3544: URL: https://github.com/apache/arrow-rs/pull/3544#discussion_r1073422580
########## arrow/src/pyarrow.rs: ########## @@ -196,7 +196,8 @@ impl PyArrowConvert for RecordBatch { let module = py.import("pyarrow")?; let class = module.getattr("RecordBatch")?; - let record = class.call_method1("from_arrays", (py_arrays, py_schema))?; + let record = class + .call_method1("from_arrays", (py_arrays, None::<PyObject>, py_schema))?; Review Comment: Looking at the change it looks like they want clients to use explicit named arguments in future, perhaps we should do so? https://pyo3.rs/v0.15.1/python_from_rust#creating-keyword-arguments. Maybe something for a follow up PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org