jduo commented on a change in pull request #8554: URL: https://github.com/apache/arrow/pull/8554#discussion_r519046814
########## File path: java/flight/flight-core/src/test/java/org/apache/arrow/flight/client/TestCookieHandling.java ########## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.arrow.flight.client; + +import java.io.IOException; + +import org.apache.arrow.flight.CallHeaders; +import org.apache.arrow.flight.CallInfo; +import org.apache.arrow.flight.CallStatus; +import org.apache.arrow.flight.Criteria; +import org.apache.arrow.flight.ErrorFlightMetadata; +import org.apache.arrow.flight.FlightClient; +import org.apache.arrow.flight.FlightInfo; +import org.apache.arrow.flight.FlightProducer; +import org.apache.arrow.flight.FlightServer; +import org.apache.arrow.flight.FlightServerMiddleware; +import org.apache.arrow.flight.FlightTestUtil; +import org.apache.arrow.flight.NoOpFlightProducer; +import org.apache.arrow.flight.RequestContext; +import org.apache.arrow.memory.BufferAllocator; +import org.apache.arrow.memory.RootAllocator; +import org.apache.arrow.util.AutoCloseables; +import org.junit.After; +import org.junit.Assert; +import org.junit.Before; +import org.junit.Ignore; +import org.junit.Test; + +/** + * Tests for correct handling of cookies from the FlightClient using {@link ClientCookieMiddleware}. + */ +public class TestCookieHandling { + private static final String SET_COOKIE_HEADER = "Set-Cookie"; + private static final String COOKIE_HEADER = "Cookie"; + private BufferAllocator allocator; + private FlightServer server; + private FlightClient client; + + private ClientCookieMiddlewareTestFactory testFactory = new ClientCookieMiddlewareTestFactory(); + private ClientCookieMiddleware cookieMiddleware = new ClientCookieMiddleware(testFactory); + + @Before + public void setup() throws Exception { + allocator = new RootAllocator(Long.MAX_VALUE); + startServerAndClient(); + } + + @After + public void cleanup() throws Exception { + cookieMiddleware = new ClientCookieMiddleware(testFactory); + AutoCloseables.close(client, server, allocator); + client = null; + server = null; + allocator = null; + } + + @Test + public void basicCookie() { + CallHeaders headersToSend = new ErrorFlightMetadata(); + headersToSend.insert(SET_COOKIE_HEADER, "k=v"); + cookieMiddleware.onHeadersReceived(headersToSend); + Assert.assertEquals("k=v", cookieMiddleware.getValidCookiesAsString()); + } + + @Test + public void cookieStaysAfterMultipleRequests() { + CallHeaders headersToSend = new ErrorFlightMetadata(); + headersToSend.insert(SET_COOKIE_HEADER, "k=v"); + cookieMiddleware.onHeadersReceived(headersToSend); + Assert.assertEquals("k=v", cookieMiddleware.getValidCookiesAsString()); + + headersToSend = new ErrorFlightMetadata(); + cookieMiddleware.onHeadersReceived(headersToSend); + Assert.assertEquals("k=v", cookieMiddleware.getValidCookiesAsString()); + + headersToSend = new ErrorFlightMetadata(); + cookieMiddleware.onHeadersReceived(headersToSend); + Assert.assertEquals("k=v", cookieMiddleware.getValidCookiesAsString()); + } + + @Test + public void cookieAutoExpires() { + CallHeaders headersToSend = new ErrorFlightMetadata(); + headersToSend.insert(SET_COOKIE_HEADER, "k=v; Max-Age=2"); + cookieMiddleware.onHeadersReceived(headersToSend); + // Note: using max-age changes cookie version from 0->1, which quotes values. + Assert.assertEquals("k=\"v\"", cookieMiddleware.getValidCookiesAsString()); + + headersToSend = new ErrorFlightMetadata(); + cookieMiddleware.onHeadersReceived(headersToSend); + Assert.assertEquals("k=\"v\"", cookieMiddleware.getValidCookiesAsString()); + + try { + Thread.sleep(5000); + } catch (InterruptedException ignored) { + } + + // Verify that the k cookie was discarded because it expired. + Assert.assertTrue(cookieMiddleware.getValidCookiesAsString().isEmpty()); + } + + @Test + public void cookieExplicitlyExpires() { + CallHeaders headersToSend = new ErrorFlightMetadata(); + headersToSend.insert(SET_COOKIE_HEADER, "k=v; Max-Age=2"); + cookieMiddleware.onHeadersReceived(headersToSend); + // Note: using max-age changes cookie version from 0->1, which quotes values. + Assert.assertEquals("k=\"v\"", cookieMiddleware.getValidCookiesAsString()); + + headersToSend = new ErrorFlightMetadata(); + headersToSend.insert(SET_COOKIE_HEADER, "k=v; Max-Age=-2"); + cookieMiddleware.onHeadersReceived(headersToSend); + + // Verify that the k cookie was discarded because the server told the client it is expired. + Assert.assertTrue(cookieMiddleware.getValidCookiesAsString().isEmpty()); Review comment: So I looked into this and found that on my Mac, the JDK explicitly checks if Max-Age == -1 (MAX_AGE_UNSPECIFIED), treat the max age as unset. In the OpenJDK 11 source code though, they treat any negative number as max age unset: https://github.com/openjdk/jdk11u-dev/blob/75a42602826c32a1053b10188ec3826eb9c0c898/src/java.base/share/classes/java/net/HttpCookie.java#L236 The RFC states that 0, and any value less than zero is supposed to be treated as immediately expired. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
