alamb commented on code in PR #4923:
URL: https://github.com/apache/arrow-datafusion/pull/4923#discussion_r1073678590
##########
datafusion/optimizer/src/push_down_filter.rs:
##########
@@ -108,13 +108,9 @@ fn on_lr_is_preserved(plan: &LogicalPlan) -> Result<(bool,
bool)> {
JoinType::Left => Ok((false, true)),
JoinType::Right => Ok((true, false)),
JoinType::Full => Ok((false, false)),
- JoinType::LeftSemi
- | JoinType::LeftAnti
- | JoinType::RightSemi
- | JoinType::RightAnti => {
- // filter_push_down does not yet support SEMI/ANTI joins with
join conditions
- Ok((false, false))
- }
+ JoinType::LeftSemi | JoinType::RightSemi => Ok((true, true)),
Review Comment:
Update 🤦 the postgres `foo SEMI JOIN bar` is being interpreted as though
`SEMI` is an alias, not a different join type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
